This repository was archived by the owner on Dec 1, 2025. It is now read-only.
Conversation
Click here to view all benchmarks. |
Collaborator
Author
|
Unit tests fail due to nested-pandas not having a release version of sort_values |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 95.45% 95.76% +0.31%
==========================================
Files 9 9
Lines 242 260 +18
==========================================
+ Hits 231 249 +18
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hombit
approved these changes
Mar 4, 2025
Collaborator
hombit
left a comment
hombit
left a comment
There was a problem hiding this comment.
Great work, thank you. I'm opening an issue for LSDB!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #86
Adds a wrapper for sort_values. This one is a bit different than the usual wrapper as dask has more of it's own functionality because sorting is a much more dask-sensitive operation. This is kind of a crude solution, but we effectively just call dasks sort_values when not sorting on nested layers, but then call a map_partitioned version of nested-pandas sort_values when working on nested layers.
These really act as two different functions under the same namespace, as top-level sorting invokes the neccesary parallelization and consequences of a shuffle that you'd expect with dask, dropping divisions. But sorting on nested layers is a contained problem that avoids dask shuffles and preserves the divisions information. We could break these out, but I think it would be better to make the functionality "feel" like nested-pandas so that would instead motivate breaking the functions out at the nested-pandas level too. The main issue I have with keeping them as one is that the kwarg set is subtly switching from one API to the other, and so things like optional kwargs may be confusing if a user switches their sorting from base->nested or vice-versa.
^But realistically, it may be fine to keep these as a single modified function until we get feedback that it's confusing in real use cases?